Issue 118431: Add watchlist rules for tools/buildbot

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 118431: Add watchlist rules for tools/buildbot (Closed)

Created:
11 years, 6 months ago by Nirnimesh

Modified:
9 years, 7 months ago

Reviewers:
John Grabowski, Nicolas Sylvain

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/tools/buildbot/

Visibility:
Public.

Description

Add watchlist rules for tools/buildbot Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18206

Patch Set 3 : '' #

Total comments: 3

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -0 lines)			Patch
	A	WATCHLISTS	View	2	1 chunk	+23 lines, -0 lines	3 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

lgtm, no need to make it executable. http://codereview.chromium.org/118431/diff/1001/2001 File WATCHLISTS (right): http://codereview.chromium.org/118431/diff/1001/2001#newcode21 Line 21: 'maruel@chromium.org'], ...

11 years, 6 months ago (2009-06-11 21:14:30 UTC) #2

John Grabowski

LGTM if the .. match problem isn't a problem http://codereview.chromium.org/118431/diff/3003/3004 File WATCHLISTS (right): http://codereview.chromium.org/118431/diff/3003/3004#newcode1 Line ...

11 years, 6 months ago (2009-06-11 23:50:22 UTC) #3

Nirnimesh

11 years, 6 months ago (2009-06-12 17:27:31 UTC) #4

http://codereview.chromium.org/118431/diff/3003/3004
File WATCHLISTS (right):

http://codereview.chromium.org/118431/diff/3003/3004#newcode15
Line 15: 'filepath': '.+',
On 2009/06/11 23:50:22, John Grabowski wrote:
> Hmm.  Would this match ../../../foo?
> 

gcl gives filenames relative to base of the repo. In this case, a ../foo will
never arrive.

Expand Messages | Collapse Messages

Issue 118431: Add watchlist rules for tools/buildbot (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages