Issue 118425: Change locationFromPosition() and locationFromLine() to use a binary search t...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 118425: Change locationFromPosition() and locationFromLine() to use a binary search t... (Closed)

Created:
11 years, 6 months ago by Søren Thygesen Gjesse

Modified:
9 years, 7 months ago

Reviewers:

CC:
v8-dev, Matt Hanselman

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Change locationFromPosition() and locationFromLine() to use a binary search to locate line numbers from position numbers. Modify test debug-sourceinfo.js to include more tests, including error conditions. Patch by Matt Hanselman, see http://codereview.chromium.org/118371. BUG=213 TEST=test/mjsunit/debug-sourceinfo.js Committed: http://code.google.com/p/v8/source/detail?r=2125

Patch Set 1 #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+122 lines, -33 lines)			Patch
	M	src/messages.js	View		3 chunks	+41 lines, -22 lines	0 comments	Download
	M	test/mjsunit/debug-sourceinfo.js	View		7 chunks	+81 lines, -11 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages