Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(781)

Issue 1184001: Don't autotranslate in incognito mode (so we don't send information... (Closed)

Created:
10 years, 9 months ago by Jay Civelli
Modified:
9 years, 7 months ago
Reviewers:
kuan
CC:
chromium-reviews, ben+cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Don't autotranslate in incognito mode (so we don't send information to the translation server without the user consent). Also added unit-tests for prefs. BUG=38107 TEST=Visit a page that triggers the translate infobar. Translate the page. Select "Always translate <lang1> to <lang2>". Open a page in lang1. The page should automatically be translated to lang2. Open an incognito window. Navigate to a page in lang1, the page should not automcatically be translated, an infobar should ask if the user wants to translate the page. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42400

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -4 lines) Patch
M chrome/browser/translate/translate_manager.cc View 1 1 chunk +6 lines, -2 lines 0 comments Download
M chrome/browser/translate/translate_manager_unittest.cc View 1 2 chunks +127 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Jay Civelli
10 years, 9 months ago (2010-03-23 18:51:46 UTC) #1
kuan
10 years, 9 months ago (2010-03-23 19:02:09 UTC) #2
LGTM.

http://codereview.chromium.org/1184001/diff/1/3
File chrome/browser/translate/translate_manager.cc (right):

http://codereview.chromium.org/1184001/diff/1/3#newcode173
chrome/browser/translate/translate_manager.cc:173: // If the user has previously
select "always translate" for this language we
nit: selected

http://codereview.chromium.org/1184001/diff/1/2
File chrome/browser/translate/translate_manager_unittest.cc (right):

http://codereview.chromium.org/1184001/diff/1/2#newcode649
chrome/browser/translate/translate_manager_unittest.cc:649: // It should have
been triggered an automatic translation to English.
nit: have been -> have

Powered by Google App Engine
This is Rietveld 408576698