Some improvements and bug fixes to traceline.

tools/traceline/svgui/traceline.js

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // TODO
 //   - spacial partitioning of the data so that we don't have to scan the
 //     entire scene every time we render.
 //   - properly clip the SVG elements when they render, right now we are just
 //     letting them go negative or off the screen.  This might give us a little
 //     bit better performance?
@@ skipping 58 matching lines @@
             " parent: " + this.parent;
   return res;
 };
 
 // A TLEvent represents a single logged event that happened on a thread.
 function TLEvent(e) {
   this.eventtype = e['eventtype'];
   this.thread = toHex(e['thread']);
   this.cpu = toHex(e['cpu']);
   this.ms = e['ms'];
+  this.done = e['done'];
   this.e = e;
 }
 
 function HTMLEscape(str) {
   return str.replace(/&/g, '&amp;').replace(/</g, '&lt;').replace(/>/g, '&gt;');
 }
 
 TLEvent.prototype.toString =
 function() {
   var res = "<b>ms:</b> " + this.ms + " " +
@@ skipping 144 matching lines @@
     var e = new TLEvent(json_data[i]);
 
     // Create a unique identifier for a thread by using the id of this data
     // set, so that they are isolated from other sets of data with the same
     // thread id, etc.  TODO don't overwrite the original...
     e.thread = set_id + '_' + e.thread;
 
     // If this is the first event ever seen on this thread, create a new
     // thread object and add it to our lists of threads.
     if (!(e.thread in this.threads_by_id)) {
-      var new_thread = new TLThread(e.thread, e.ms, e.ms);
+      var end_ms = e.done ? e.done : e.ms;
+      var new_thread = new TLThread(e.thread, e.ms, end_ms);
       this.threads_by_id[new_thread.id] = this.threads.length;
       this.threads.push(new_thread);
     }
 
     var thread = this.threads[this.threads_by_id[e.thread]];
     thread.AddEvent(e);
 
     // Keep trace of the time of the last event seen.
-    if (e.ms > this.endms) this.endms = e.ms;
-    if (e.ms > thread.endms) thread.endms = e.ms;
+    var end_ms = e.done ? e.done : e.ms;
+    if (end_ms > this.endms) this.endms = end_ms;
+    if (end_ms > thread.endms) thread.endms = end_ms;
 
     switch(e.eventtype) {
       case 'EVENT_TYPE_THREADNAME':
         thread.name = e.e['threadname'];
         break;
       case 'EVENT_TYPE_CREATETHREAD':
         tiez[e.e['eventid']] = e;
         break;
       case 'EVENT_TYPE_THREADBEGIN':
         var pei = e.e['parenteventid'];
@@ skipping 369 matching lines @@
   // Remove everything from the DOM.
   while (svg.firstChild)
     svg.removeChild(svg.firstChild);
 
   // Don't actually need this, but you can't transform on an svg element,
   // so it's nice to have a <g> around for transforms...
   var svgg = document.createElementNS(svgNS, 'g');
 
   var dur = this.kTimelineWidthPx / curzoom;
 
+  function min(a, b) {
+    return a < b ? a : b;
+  }
+
+  function max(a, b) {
+    return a > b ? a : b;
+  }
+
   function timeToPixel(x) {
-    var x = Math.floor(x*curzoom);
+    // TODO(deanm): This clip is a bit shady.
+    var x = min(max(Math.floor(x*curzoom), -100), 2000);
     return (x == 0 ? 1 : x);
   }
 
   for (var i = 0, il = stuff.length; i < il; ++i) {
     var thing = stuff[i];
     if (!thing.hittest(startms, startms+dur))
       continue;
 
 
     if (thing.type == SVGSceneRect) {
       var rect = document.createElementNS('http://www.w3.org/2000/svg', 'rect');
       rect.setAttributeNS(null, 'class', thing.klass)
-      // TODO timeToPixel could be negative, clamp it at 0
       rect.setAttributeNS(null, 'x', timeToPixel(thing.x - startms));
       rect.setAttributeNS(null, 'y', thing.y);
-      // TODO thing.width can be larger than our current view, clamp it.
       rect.setAttributeNS(null, 'width', timeToPixel(thing.width));
       rect.setAttributeNS(null, 'height', thing.height);
       rect.msg = thing.msg;
       svgg.appendChild(rect);
     } else if (thing.type == SVGSceneLine) {
       var line = document.createElementNS('http://www.w3.org/2000/svg', 'line');
       line.setAttributeNS(null, 'class', thing.klass)
-      // TODO timeToPixel could be negative, clamp it at 0
       line.setAttributeNS(null, 'x1', timeToPixel(thing.x1 - startms));
       line.setAttributeNS(null, 'y1', thing.y1);
       line.setAttributeNS(null, 'x2', timeToPixel(thing.x2 - startms));
       line.setAttributeNS(null, 'y2', thing.y2);
       line.msg = thing.msg;
       svgg.appendChild(line);
     }
 
     ++count;
   }
 
   // Append the 'g' element on after we've build it.
   svg.appendChild(svgg);
 
   return count;
 };