Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 118377: Some improvements and bug fixes to traceline. (Closed)

Created:
11 years, 6 months ago by Dean McNamee
Modified:
9 years, 7 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Some improvements and bug fixes to traceline. SVG UI: - Fix some TODOs about clipping SVG objects to the scene. This fixes bugs where a rectangle is too large and not displayed at all. - Fix the calculation of the thread endms done time. This fixes the thread gray background not being drawn for the full length of the thread. Traceline tracer: - Enable PatchCreateThread on XP. This fixes not having the thread creation information output in the JSON files on XP. Still doesn't work on Vista. - Print the manual-quit message to stderr, so it doesn't end up in the JSON. - Cast a symbol API callback to compile with both older and newer SDKs. - Add two small scripts for breaking apart large JSON files into smaller pieces, so that the Python tools can handle processing the smaller files.

Patch Set 1 #

Patch Set 2 : Ride the snake #

Total comments: 2

Patch Set 3 : for in file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -11 lines) Patch
M tools/traceline/svgui/traceline.js View 6 chunks +16 lines, -7 lines 0 comments Download
M tools/traceline/traceline/main.cc View 2 chunks +4 lines, -3 lines 0 comments Download
A tools/traceline/traceline/scripts/filter_split.sh View 1 chunk +15 lines, -0 lines 0 comments Download
A tools/traceline/traceline/scripts/split.py View 2 1 chunk +25 lines, -0 lines 0 comments Download
M tools/traceline/traceline/sym_resolver.h View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Dean McNamee
11 years, 6 months ago (2009-06-08 10:39:08 UTC) #1
M-A Ruel
mostly rubberstamp lgtm Especially the ruby part, dude, ruby? I'm pretty sure it's not installed ...
11 years, 6 months ago (2009-06-08 14:09:23 UTC) #2
Dean McNamee
Ok ok, I rewrote it in boring python.
11 years, 6 months ago (2009-06-08 14:36:36 UTC) #3
M-A Ruel
11 years, 6 months ago (2009-06-08 14:38:22 UTC) #4
lgtm with optional nits

http://codereview.chromium.org/118377/diff/7/11
File tools/traceline/traceline/scripts/split.py (right):

http://codereview.chromium.org/118377/diff/7/11#newcode16
Line 16: l = sys.stdin.readline()
I think you could have written:
  for l in sys.stdin:

http://codereview.chromium.org/118377/diff/7/11#newcode19
Line 19: if l == "},\r\n":
with this, it'll be more agnostic.
if l.strip() == "},":

Powered by Google App Engine
This is Rietveld 408576698