Introduce an API to force the deletion of a property ignoring...

Introduce an API to force the deletion of a property ignoring
interceptors and dont-delete attributes.

Minor change to the behavior of eval: throw exception when calling
eval in a context for which the global has been detached.  This
matches the behavior of both Firefox and Safari post navigation in the
browser.

Committed: http://code.google.com/p/v8/source/detail?r=2118

[Kasper Lund, 2009-06-08 09:22:40]

LGTM.

http://codereview.chromium.org/118374/diff/1/6
File src/v8natives.js (right):

http://codereview.chromium.org/118374/diff/1/6#newcode119
Line 119: var this_is_global_receiver = this === global_receiver;
I would probably put parentheses around the boolean expression to make the code
a bit easier to read.

http://codereview.chromium.org/118374/diff/1/2
File test/cctest/test-api.cc (right):

http://codereview.chromium.org/118374/diff/1/2#newcode4636
Line 4636: context0->SetSecurityToken(v8_str("<security token>"));
This seems a bit fishy. Do you want the two contexts to share the same security
token? I guess so. In that case, I would make sure to use the same object by
stuffing "<security token>" in a handle - instead of just piggybacking on the
v8_str to return a symbol.

http://codereview.chromium.org/118374/diff/1/2#newcode6786
Line 6786: const v8::AccessorInfo& info) {
Line too long?

[Mads Ager (chromium), 2009-06-08 09:31:05]

http://codereview.chromium.org/118374/diff/1/6
File src/v8natives.js (right):

http://codereview.chromium.org/118374/diff/1/6#newcode119
Line 119: var this_is_global_receiver = this === global_receiver;
On 2009/06/08 09:22:40, Kasper Lund wrote:
> I would probably put parentheses around the boolean expression to make the
code
> a bit easier to read.

Done.

http://codereview.chromium.org/118374/diff/1/2
File test/cctest/test-api.cc (right):

http://codereview.chromium.org/118374/diff/1/2#newcode4636
Line 4636: context0->SetSecurityToken(v8_str("<security token>"));
On 2009/06/08 09:22:40, Kasper Lund wrote:
> This seems a bit fishy. Do you want the two contexts to share the same
security
> token? I guess so. In that case, I would make sure to use the same object by
> stuffing "<security token>" in a handle - instead of just piggybacking on the
> v8_str to return a symbol.

Thanks!  I don't need to set the security token for the contexts and I have
removed it.  I'm explicitly performing operations through the API with no
security checks.  (And even if I needed it, this style is indeed fishy.)

http://codereview.chromium.org/118374/diff/1/2#newcode6786
Line 6786: const v8::AccessorInfo& info) {
On 2009/06/08 09:22:40, Kasper Lund wrote:
> Line too long?

Done.