Add InputApi.ReadFile() and presubmit_canned_checks.CheckChangeHasNoCR().

presubmit_support.py

 #!/usr/bin/python
 # Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Enables directory-specific presubmit checks to run at upload and/or commit.
 """
 
-__version__ = '1.3'
+__version__ = '1.3.1'
 
 # TODO(joi) Add caching where appropriate/needed. The API is designed to allow
 # caching (between all different invocations of presubmit scripts for a given
 # change). We should add it as our presubmit scripts start feeling slow.
 
 import cPickle  # Exposed through the API.
 import cStringIO  # Exposed through the API.
 import exceptions
 import fnmatch
 import glob
@@ skipping 244 matching lines @@
         the AffectedFile instance of the current file;
         integer line number (1-based); and
         the contents of the line as a string.
 
     Note: The cariage return (LF or CR) is stripped off.
     """
     return InputApi._RightHandSideLinesImpl(
         filter(lambda x: x.IsTextFile(),
                self.AffectedFiles(include_deletes=False)))
 
+  def ReadFile(self, file, mode='r'):
+    """Reads an arbitrary file.
+    
+    Deny reading anything outside the repository."""

[Jói Sigurðsson, 2009/06/08 10:52:50]

For consistency with the rest of the code, please do multi-line docstrings with
the trailing quote on a separate line:

"""foo
blat
gat.
"""

Single-line docstrings should still be on a single line,

"""Foo blat gat."""

+    if isinstance(file, AffectedFile):
+      file = file.AbsoluteLocalPath()
+    if not file.startswith(self.change.RepositoryRoot()):
+      raise IOError('Access outside the repository root is denied.')
+    return gcl.ReadFile(file, mode)
+
   @staticmethod
   def _RightHandSideLinesImpl(affected_files):
     """Implements RightHandSideLines for InputApi and GclChange."""
     for af in affected_files:
       lines = af.NewContents()
       line_number = 0
       for line in lines:
         line_number += 1
         yield (af, line_number, line)
 
@@ skipping 450 matching lines @@
   return not DoPresubmitChecks(gcl.ChangeInfo('No name', 0, 0, '', files),
                                options.commit,
                                options.verbose,
                                sys.stdout,
                                sys.stdin,
                                default_presubmit=None)
 
 
 if __name__ == '__main__':
   sys.exit(Main(sys.argv))