Add InputApi.ReadFile() and presubmit_canned_checks.CheckChangeHasNoCR().

presubmit_canned_checks.py

 #!/usr/bin/env python
 # Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Generic presubmit checks that can be reused by other presubmit checks."""
 
 
 def CheckChangeHasTestField(input_api, output_api):
   """Requires that the changelist have a TEST= field."""
@@ skipping 50 matching lines @@
   return []
 
 
 def CheckDoNotSubmit(input_api, output_api):
   return (
       CheckDoNotSubmitInDescription(input_api, output_api) +
       CheckDoNotSubmitInFiles(input_api, output_api)
       )
 
 
+def CheckChangeHasNoCR(input_api, output_api):
+  """Checks that there are no \r, \r\n (CR or CRLF) characters in any of the
+  text files to be submitted.
+  """
+  outputs = []
+  for f in input_api.AffectedTextFiles():
+    if '\r' in input_api.ReadFile(f, 'rb'):
+      outputs.append(output_api.PresubmitPromptWarning(
+          "Found a CR character in %s" % f.LocalPath()))
+  return outputs
+
+
 def CheckChangeHasNoTabs(input_api, output_api):
   """Checks that there are no tab characters in any of the text files to be
   submitted.
   """
   for f, line_num, line in input_api.RightHandSideLines():
     if '\t' in line:
       return [output_api.PresubmitPromptWarning(
           "Found a tab character in %s, line %s" %
           (f.LocalPath(), line_num))]
   return []
@@ skipping 58 matching lines @@
     except ImportError:
       outputs.append(message_type("Failed to load %s" % unit_test,
                                   long_text=input_api.traceback.format_exc()))
 
   results = input_api.unittest.TextTestRunner(verbosity=0).run(
       input_api.unittest.TestSuite(tests_suite))
   if not results.wasSuccessful():
     outputs.append(message_type("%d unit tests failed." %
                                 (len(results.failures) + len(results.errors))))
   return outputs