Issue 118370: Add InputApi.ReadFile() and presubmit_canned_checks.CheckChangeHasNoCR().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 118370: Add InputApi.ReadFile() and presubmit_canned_checks.CheckChangeHasNoCR(). (Closed)

Created:
11 years, 6 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
Jói Sigurðsson

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Add InputApi.ReadFile() and presubmit_canned_checks.CheckChangeHasNoCR(). ReadFile limits to reading files inside the repository. CheckChangeHasNoCR reads the text files looking for \r and fails if found. TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17857

Patch Set 1 #

Patch Set 2 : version #

Patch Set 3 : Use mode 'rb' #

Total comments: 1

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+84 lines, -7 lines)			Patch
M	presubmit_canned_checks.py	View	1 2	1 chunk	+12 lines, -0 lines	0 comments	Download
M	presubmit_support.py	View	1	2 chunks	+11 lines, -1 line	1 comment	Download
M	tests/presubmit_unittest.py	View	1 2	5 chunks	+61 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jói Sigurðsson

11 years, 6 months ago (2009-06-08 10:52:50 UTC) #2

LGTM with nit

http://codereview.chromium.org/118370/diff/1008/7
File presubmit_support.py (right):

http://codereview.chromium.org/118370/diff/1008/7#newcode277
Line 277: Deny reading anything outside the repository."""
For consistency with the rest of the code, please do multi-line docstrings with
the trailing quote on a separate line:

"""foo
blat
gat.
"""

Single-line docstrings should still be on a single line,

"""Foo blat gat."""

Expand Messages | Collapse Messages