Issue 118359: Don't call NPP_SetWindow before we have the plugin geometry.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 118359: Don't call NPP_SetWindow before we have the plugin geometry. (Closed)

Created:
11 years, 6 months ago by jam

Modified:
9 years, 7 months ago

Reviewers:
ananta

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Don't call NPP_SetWindow before we have the plugin geometry. Note: the full fix to the bug also needs Ananta's change at http://codereview.chromium.org/119200 Bug=12993 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17920

Patch Set 3 : '' #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -42 lines)			Patch
M	chrome/browser/renderer_host/render_widget_host_view_win.cc	View	1 2	1 chunk	+13 lines, -8 lines	0 comments	Download
M	chrome/common/render_messages.h	View	1 2	3 chunks	+4 lines, -0 lines	0 comments	Download
M	webkit/glue/plugins/webplugin_delegate_impl.cc	View	1 2	1 chunk	+4 lines, -4 lines	0 comments	Download
M	webkit/glue/webplugin.h	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	webkit/glue/webplugin_impl.h	View	1 2	2 chunks	+3 lines, -1 line	0 comments	Download
M	webkit/glue/webplugin_impl.cc	View	1 2	5 chunks	+28 lines, -29 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ananta

LGTM http://codereview.chromium.org/118359/diff/1004/1010 File chrome/common/render_messages.h (right): http://codereview.chromium.org/118359/diff/1004/1010#newcode957 Line 957: l->append(L", "); Should we also log rects_valid ...

11 years, 6 months ago (2009-06-09 01:18:04 UTC) #2

jam

http://codereview.chromium.org/118359/diff/1004/1010 File chrome/common/render_messages.h (right): http://codereview.chromium.org/118359/diff/1004/1010#newcode957 Line 957: l->append(L", "); On 2009/06/09 01:18:04, ananta wrote: > ...

11 years, 6 months ago (2009-06-09 01:35:30 UTC) #3

LGTM

Expand Messages | Collapse Messages

Issue 118359: Don't call NPP_SetWindow before we have the plugin geometry. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages