Issue 118355: Added patchset persistence in gcl, this is necessary to implement a presubmit queue.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 118355: Added patchset persistence in gcl, this is necessary to implement a presubmit queue. (Closed)

Created:
11 years, 6 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
Jói Sigurðsson

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Added patchset persistence in gcl, this is necessary to implement a presubmit queue. Now enforces ChangeInfo.issue (and .patchset) to be a int. Renamed LoadChangelistInfo() to ChangeInfo.Load(). Removed ChangeInfo.__init__() default parameters. TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17836

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : Propragate in presubmit #

Patch Set 5 : Add a GclChange unit test #

Patch Set 6 : . #

Patch Set 7 : Fixed ChangeInfo.Load #

Patch Set 8 : Fix ChangeInfo.Save() and add unit tests #

Patch Set 9 : Take 2 #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+192 lines, -120 lines)			Patch
M	gcl.py	View	1 2 3 4 5 6 7	14 chunks	+93 lines, -86 lines	0 comments	Download
M	presubmit_support.py	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	tests/gcl_unittest.py	View	1 2 3 4 5 6 7 8	7 chunks	+65 lines, -20 lines	0 comments	Download
M	tests/presubmit_unittest.py	View	1 2 3 4	13 chunks	+32 lines, -14 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

I changed the format to use "issue, patchset" instead of adding a new separator, which ...

11 years, 6 months ago (2009-06-06 18:44:06 UTC) #3

LGTM

Expand Messages | Collapse Messages