Issue 118341: Add a mipmap-like divide-by-two image scaling algorithm. I am going to use th...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 118341: Add a mipmap-like divide-by-two image scaling algorithm. I am going to use th... (Closed)

Created:
11 years, 6 months ago by brettw

Modified:
9 years, 7 months ago

Reviewers:
cpu_(ooo_6.6-7.5)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Add a mipmap-like divide-by-two image scaling algorithm. I am going to use this for on-the-fly generated thumbnails. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17957

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 3

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+207 lines, -7 lines)			Patch
M	skia/ext/image_operations.h	View	1	3 chunks	+20 lines, -7 lines	0 comments	Download
M	skia/ext/image_operations.cc	View	1	1 chunk	+74 lines, -0 lines	3 comments	Download
M	skia/ext/image_operations_unittest.cc	View	1	1 chunk	+113 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

cpu_(ooo_6.6-7.5)

11 years, 6 months ago (2009-06-09 17:32:42 UTC) #2

LGTM. Some nits below

http://codereview.chromium.org/118341/diff/8/1005
File skia/ext/image_operations.cc (right):

http://codereview.chromium.org/118341/diff/8/1005#newcode632
Line 632: 
do we care if the source bitmap is not KARG_888 ?

http://codereview.chromium.org/118341/diff/8/1005#newcode635
Line 635: (bitmap.width() + 1) / 2, (bitmap.height() + 1) / 2);
vertical aligment

http://codereview.chromium.org/118341/diff/8/1005#newcode677
Line 677: 
note that there must be some implicit division by 4 here which I think is in the
shift. I would be good to note.

Expand Messages | Collapse Messages