Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 118339: Linux: Special case focus handling so that we don't tell webkit it's lost foc... (Closed)

Created:
11 years, 6 months ago by Evan Stade
Modified:
9 years, 6 months ago
Reviewers:
tony, Evan Martin
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Linux: Special case focus handling so that we don't tell webkit it's lost focus when a context menu is showing. BUG=13404, 13554 TEST=copy/paste *via the right-click context menu* works as expected in gmail. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18225

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -17 lines) Patch
M chrome/browser/renderer_host/render_widget_host_view.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_gtk.h View 3 chunks +13 lines, -9 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_gtk.cc View 3 chunks +16 lines, -4 lines 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu_gtk.h View 4 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu_gtk.cc View 3 chunks +11 lines, -2 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents_view_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Evan Stade
11 years, 6 months ago (2009-06-05 22:34:13 UTC) #1
Evan Stade
note that a much simpler (one line) solution would be to only call Blur() when ...
11 years, 6 months ago (2009-06-05 23:01:52 UTC) #2
Evan Martin
Yeah, and we still want to Blur() when we focus the omnibox.
11 years, 6 months ago (2009-06-05 23:03:25 UTC) #3
Evan Stade
> Yeah, and we still want to Blur() when we focus the omnibox. well, we ...
11 years, 6 months ago (2009-06-05 23:05:11 UTC) #4
Evan Stade
This patch doesn't perfectly match GTK apps, which usually do blur the selection when you ...
11 years, 6 months ago (2009-06-11 00:57:48 UTC) #5
tony
11 years, 6 months ago (2009-06-11 20:21:48 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld 408576698