Add support for printing selection only flag. This only adds the flag to the ...

Add support for printing selection only flag. This only adds the flag to the IPC and implements the Windows dialog interaction but does not enable this just yet.

BUG=http://crbug.com/1682
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17867

[Sverrir, 2009-06-05 22:18:43]

Continued improvement to printing stuff.  This is the scaffolding for print
selection.

[M-A Ruel, 2009-06-06 01:08:56]

I'm not sure about the selection_only being in ViewMsg_PrintPages_Params vs
ViewMsg_Print_Params, the rest lgtm.

http://codereview.chromium.org/118338/diff/1/3
File chrome/browser/printing/win_printing_context.cc (right):

http://codereview.chromium.org/118338/diff/1/3#newcode514
Line 514: LPPRINTPAGERANGE page_ranges = NULL;
Use PRINTPAGERANGE* instead.

http://codereview.chromium.org/118338/diff/1/13
File chrome/common/render_messages.h (right):

http://codereview.chromium.org/118338/diff/1/13#newcode328
Line 328: bool selection_only;
Shouldn't that be in ViewMsg_Print_Params?

http://codereview.chromium.org/118338/diff/1/16
File chrome/renderer/print_web_view_helper.cc (right):

http://codereview.chromium.org/118338/diff/1/16#newcode136
Line 136: DCHECK(!print_settings.selection_only);
Humm you shouldn't leave the DCHECK because we can hit it easily. Use
NOTIMPLEMENTED() instead.

[Sverrir, 2009-06-08 16:03:12]

Made all suggested changes.  Will submit after try bot round...

http://codereview.chromium.org/118338/diff/1/3
File chrome/browser/printing/win_printing_context.cc (right):

http://codereview.chromium.org/118338/diff/1/3#newcode514
Line 514: LPPRINTPAGERANGE page_ranges = NULL;
On 2009/06/06 01:08:56, Marc-Antoine Ruel wrote:
> Use PRINTPAGERANGE* instead.

Done.

http://codereview.chromium.org/118338/diff/1/13
File chrome/common/render_messages.h (right):

http://codereview.chromium.org/118338/diff/1/13#newcode328
Line 328: bool selection_only;
On 2009/06/06 01:08:56, Marc-Antoine Ruel wrote:
> Shouldn't that be in ViewMsg_Print_Params?

True, that's better - Changing that and uploading again.

http://codereview.chromium.org/118338/diff/1/16
File chrome/renderer/print_web_view_helper.cc (right):

http://codereview.chromium.org/118338/diff/1/16#newcode136
Line 136: DCHECK(!print_settings.selection_only);
On 2009/06/06 01:08:56, Marc-Antoine Ruel wrote:
> Humm you shouldn't leave the DCHECK because we can hit it easily. Use
> NOTIMPLEMENTED() instead.

Done