Issue 118317: DEPS cleanup.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 118317: DEPS cleanup. (Closed)

Created:
11 years, 6 months ago by Lei Zhang

Modified:
9 years, 7 months ago

Reviewers:
tony, ncarter (slow), Zachary Kuznia, tim (not reviewing), idana

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

DEPS cleanup. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18312

Patch Set 1 #

Total comments: 2

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -17 lines)			Patch
M	chrome/app/DEPS	View	1 chunk	+0 lines, -2 lines	1 comment	Download
M	chrome/browser/DEPS	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	chrome/common/gfx/DEPS	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	chrome/renderer/DEPS	View	2 chunks	+1 line, -3 lines	1 comment	Download
D	chrome/test/perf/DEPS	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/tools/DEPS	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

tony

LGTM, just pulling in tim to verify the chrome/personalization directories. http://codereview.chromium.org/118317/diff/1/3 File chrome/app/DEPS (left): http://codereview.chromium.org/118317/diff/1/3#oldcode5 ...

11 years, 6 months ago (2009-06-05 20:49:14 UTC) #2

tony

Pull in a few other p13n people. Is this change to DEPS (include paths) ok?

11 years, 6 months ago (2009-06-12 18:45:40 UTC) #4

idana

11 years, 6 months ago (2009-06-12 19:14:54 UTC) #5

[-jhaas]
[+zork,nick]

Nick/Zork - can you please take a look at this?

Expand Messages | Collapse Messages