Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(616)

Unified Diff: net/http/http_network_transaction.cc

Issue 118316: Send the "Proxy-Connection: keep-alive" header with HTTP CONNECT... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/http/http_network_transaction_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_network_transaction.cc
===================================================================
--- net/http/http_network_transaction.cc (revision 17759)
+++ net/http/http_network_transaction.cc (working copy)
@@ -104,8 +104,10 @@
const std::string& authorization_headers,
std::string* request_headers) {
// RFC 2616 Section 9 says the Host request-header field MUST accompany all
- // HTTP/1.1 requests.
- *request_headers = StringPrintf("CONNECT %s HTTP/1.1\r\nHost: %s\r\n",
+ // HTTP/1.1 requests. Add "Proxy-Connection: keep-alive" for compat with
+ // HTTP/1.0 proxies such as Squid (required for NTLM authentication).
+ *request_headers = StringPrintf(
+ "CONNECT %s HTTP/1.1\r\nHost: %s\r\nProxy-Connection: keep-alive\r\n",
GetHostAndPort(request_info->url).c_str(),
GetHostAndOptionalPort(request_info->url).c_str());
« no previous file with comments | « no previous file | net/http/http_network_transaction_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698