Issue 118306: Add an ability to explicitly specify path to d8 shell to linux-tick-processor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 118306: Add an ability to explicitly specify path to d8 shell to linux-tick-processor. (Closed)

Created:
11 years, 6 months ago by Mikhail Naganov

Modified:
9 years, 7 months ago

Reviewers:
Kevin Millikin (Chromium)

CC:
v8-dev

Visibility:
Public.

Description

Add an ability to explicitly specify path to d8 shell to linux-tick-processor. Committed: http://code.google.com/p/v8/source/detail?r=2113

Patch Set 1 #

Total comments: 2

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -10 lines)			Patch
	M	tools/linux-tick-processor	View		1 chunk	+8 lines, -10 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Chromium)

One small adjustment. Otherwise, LGTM and thanks. http://codereview.chromium.org/118306/diff/1/2 File tools/linux-tick-processor (right): http://codereview.chromium.org/118306/diff/1/2#newcode8 Line 8: [ ...

11 years, 6 months ago (2009-06-05 13:37:27 UTC) #2

Mikhail Naganov

11 years, 6 months ago (2009-06-05 15:49:41 UTC) #3

http://codereview.chromium.org/118306/diff/1/2
File tools/linux-tick-processor (right):

http://codereview.chromium.org/118306/diff/1/2#newcode8
Line 8: [ -x $d8_exec ] || scons -C $D8_PATH d8
On 2009/06/05 13:37:27, Kevin Millikin wrote:
> I think this second half needs to be:
> 
> scons -C $D8_PATH -Y $tools_path/.. d8
> 
> to cover the case where there is no SConstruct file in $D8_PATH (that's my
> case).

OK, done. Please let me know if it will not work.

Expand Messages | Collapse Messages