Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1198)

Unified Diff: third_party/lcov/bin/mcov

Issue 118298: Add unit_tests (Chrome browser unit tests) to Mac/Linux coverage.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome.gyp ('k') | tools/code_coverage/coverage_posix.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/lcov/bin/mcov
===================================================================
--- third_party/lcov/bin/mcov (revision 17371)
+++ third_party/lcov/bin/mcov (working copy)
@@ -252,8 +252,10 @@
my $number;
local *INPUT;
- ## TODO(ajeya): Exit more gracefully here.
- open(INPUT, $filename) or die("ERROR: cannot read $filename!\n");
+ if (!open(INPUT, $filename)) {
+ warn("WARNING: cannot read $filename!\n");
+ return @result;
+ }
# Parse gcov output and populate the array
my @lines = <INPUT>;
« no previous file with comments | « chrome/chrome.gyp ('k') | tools/code_coverage/coverage_posix.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698