Issue 118298: Add unit_tests (Chrome browser unit tests) to Mac/Linux coverage....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 118298: Add unit_tests (Chrome browser unit tests) to Mac/Linux coverage.... (Closed)

Created:
11 years, 6 months ago by John Grabowski

Modified:
9 years, 6 months ago

Reviewers:
Randall Spangler

CC:
chromium-reviews_googlegroups.com, TVL

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Add unit_tests (Chrome browser unit tests) to Mac/Linux coverage. Minor fixes to coverage related scripts. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17785

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+70 lines, -26 lines)			Patch
M	build/linux/chrome_linux.croc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	build/mac/chrome_mac.croc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	third_party/lcov/bin/mcov	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	tools/code_coverage/coverage_posix.py	View	7 chunks	+63 lines, -22 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Randall Spangler

LGTM What additional source directories should Croc look at now? We'll need to change build/linux/chrome_linux.croc ...

11 years, 6 months ago (2009-06-05 16:18:57 UTC) #2

John Grabowski

11 years, 6 months ago (2009-06-05 19:38:08 UTC) #3

On 2009/06/05 16:18:57, Randall Spangler wrote:
> LGTM
> 
> What additional source directories should Croc look at now?  We'll need to
> change build/linux/chrome_linux.croc and build/mac/chrome_mac.croc to include
> those.

Croc files updated; please re-review.
Where would I add a new "root" to handle the V8 files compiled with "-I." ?

Expand Messages | Collapse Messages