Issue 118297: Retry. I believe the code (with your width() * bbp fix) is correct....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 118297: Retry. I believe the code (with your width() * bbp fix) is correct.... (Closed)

Created:
11 years, 6 months ago by Glen Murphy

Modified:
9 years, 5 months ago

Reviewers:
Lei Zhang, ncarter (slow), try_nick_at_chromium_org

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Retry. I believe the code (with your width() * bbp fix) is correct. The UMR errors occur when the source image contain alpha. I believe the issue comes from webkit glue image decoder, and the reason this only started triggering valgrind errors is that the old ones were masked by the change detailed in bug 12640 Also adds valgrind suppression for the new code. BUG=12891, 12640 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17792

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -5 lines)			Patch
	M	base/gfx/png_encoder.cc	View		2 chunks	+37 lines, -5 lines	0 comments	Download
	M	tools/valgrind/suppressions_mac.txt	View		1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

11 years, 6 months ago (2009-06-05 23:01:47 UTC) #5

On 2009/06/05 22:34:35, Glen Murphy wrote:
> Lei, could you review the valgrind change?

LGTM if it works for you.

Expand Messages | Collapse Messages