Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: webkit/glue/webaccessibilitymanager_impl.cc

Issue 118206: Fixes an issue where the MSAA information was not reported back correctly to ... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/glue/webaccessibilitymanager_impl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/glue/webaccessibilitymanager_impl.cc
===================================================================
--- webkit/glue/webaccessibilitymanager_impl.cc (revision 17645)
+++ webkit/glue/webaccessibilitymanager_impl.cc (working copy)
@@ -35,7 +35,7 @@
// class WebAccessibilityManagerImpl
WebAccessibilityManagerImpl::WebAccessibilityManagerImpl()
: root_(new GlueAccessibilityObjectRoot),
- acc_obj_id_(0) {
+ acc_obj_id_(1000) {
}
WebAccessibilityManagerImpl::~WebAccessibilityManagerImpl() {
@@ -55,7 +55,10 @@
int object_id = in_params.object_id;
int child_id = in_params.child_id;
- if (!in_params.direct_descendant) {
+ // Since ids assigned by Chrome starts at 1000, whereas platform-specific ids
+ // used to reference a child will be in a wholly different range, we know
+ // that any id that high should be treated as a non-direct descendant.
+ if (in_params.child_id >= 1000) {
// Object is not a direct child, re-map the input parameters accordingly.
// The object to be retrieved is referred to by the |in_params.child_id|, as
// a result of e.g. a focus event. The local |child_id| is set to 0, to
@@ -247,7 +250,7 @@
}
int_to_glue_acc_obj_map_.erase(it);
- if (acc_obj_id == 0) {
+ if (acc_obj_id == 1000) {
// Invalidate root.
root_->acc_obj_root_ = 0;
}
« no previous file with comments | « webkit/glue/webaccessibilitymanager_impl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698