Issue 1182001: Remove vendor specific CSS prefixes.

Issue 1182001: Remove vendor specific CSS prefixes. (Closed)

Created:
10 years, 9 months ago by arv (Not doing code reviews)

Modified:
9 years, 4 months ago

Reviewers:
slightlyoff

CC:
chromium-reviews, ncarter (slow), idana, ben+cc_chromium.org, arv (Not doing code reviews), Paweł Hajdan Jr., tim (not reviewing)

Visibility:
Public.

Description

Remove vendor specific CSS prefixes. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42488

Patch Set 1 #

Total comments: 3

Patch Set 2 : ? #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+170 lines, -172 lines)			Patch
M	chrome/browser/resources/about_credits.html	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/about_memory.html	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/resources/about_memory_linux.html	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/resources/about_memory_mac.html	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/resources/about_os_credits.html	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/bookmark_manager/css/bmm.css	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/bookmark_manager/css/list.css	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/bookmark_manager/css/tree.css	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/filebrowse.html	View	4 chunks	+7 lines, -7 lines	0 comments	Download
M	chrome/browser/resources/incognito_tab.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/new_new_tab.css	View	11 chunks	+16 lines, -17 lines	0 comments	Download
M	chrome/browser/resources/safe_browsing_malware_block.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/safe_browsing_multiple_threat_block.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/safe_browsing_phishing_block.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/security/resources/ssl_error.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/security/resources/ssl_roadblock.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/resources/about_sync.html	View	6 chunks	+15 lines, -16 lines	0 comments	Download
M	chrome/browser/sync/resources/gaia_login.html	View	16 chunks	+106 lines, -106 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

slightlyoff

10 years, 9 months ago (2010-03-23 22:24:21 UTC) #2

LGTM

http://codereview.chromium.org/1182001/diff/1/3
File chrome/browser/resources/about_memory.html (right):

http://codereview.chromium.org/1182001/diff/1/3#newcode310
chrome/browser/resources/about_memory.html:310: border-radius: 0;
use of space between property and value seems inconsistent in these style
sheets. Is there a reason for one style over another?

http://codereview.chromium.org/1182001/diff/1/12
File chrome/browser/resources/new_new_tab.css (right):

http://codereview.chromium.org/1182001/diff/1/12#newcode82
chrome/browser/resources/new_new_tab.css:82: -webkit-transition: background-size
.15s;
could this be 0.15s? Without something before the dot, it reads oddly.

http://codereview.chromium.org/1182001/diff/1/12#newcode255
chrome/browser/resources/new_new_tab.css:255: border-radius .15s,
-webkit-box-shadow .15s;
ditto.

Expand Messages | Collapse Messages