Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Issue 118192: Fetch last change (revision) info in a separate action that can run... (Closed)

Created:
11 years, 6 months ago by sgk
Modified:
9 years, 5 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews_googlegroups.com, Mark Mentovai, Nicolas Sylvain, Michael Moss, bradnelson, darin (slow to review)
Visibility:
Public.

Description

Fetch last change (revision) info in a separate action that can run every build, instead of having it occur as a side effect of updating some other target for which we want to use normal up-to-date checks. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17634

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 4

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+181 lines, -70 lines) Patch
M base/base.gyp View 1 2 3 4 3 chunks +8 lines, -3 lines 0 comments Download
M build/all.gyp View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A build/util/build_util.gyp View 1 2 3 4 1 chunk +34 lines, -0 lines 0 comments Download
A build/util/lastchange.py View 1 2 3 1 chunk +121 lines, -0 lines 0 comments Download
M chrome/chrome.gyp View 1 2 3 4 3 chunks +16 lines, -14 lines 0 comments Download
M chrome/tools/build/version.py View 1 2 3 4 3 chunks +1 line, -53 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sgk
This is for preliminary comments (although it does pass on the try servers). This isolates ...
11 years, 6 months ago (2009-06-03 23:04:50 UTC) #1
M-A Ruel
lgtm http://codereview.chromium.org/118192/diff/1001/1003 File build/util/lastchange.py (right): http://codereview.chromium.org/118192/diff/1001/1003#newcode112 Line 112: opts, args = getopt.getopt(argv[1:], short_options, long_options) nit: ...
11 years, 6 months ago (2009-06-04 00:24:28 UTC) #2
sgk
http://codereview.chromium.org/118192/diff/1001/1003 File build/util/lastchange.py (right): http://codereview.chromium.org/118192/diff/1001/1003#newcode129 Line 129: sys.stderr.write('Use -h to get help.') On 2009/06/04 00:24:28, ...
11 years, 6 months ago (2009-06-04 00:52:54 UTC) #3
sgk
11 years, 6 months ago (2009-06-04 01:42:10 UTC) #4
http://codereview.chromium.org/118192/diff/1001/1003
File build/util/lastchange.py (right):

http://codereview.chromium.org/118192/diff/1001/1003#newcode112
Line 112: opts, args = getopt.getopt(argv[1:], short_options, long_options)
On 2009/06/04 00:24:28, M-A wrote:
> nit: optparser is much cleaner

Done (whiling away the time waiting for a green tree...)

Powered by Google App Engine
This is Rietveld 408576698