Reduce header dependencies in base/

chrome/browser/renderer_host/audio_renderer_host.h

 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // AudioRendererHost serves audio related requests from AudioRenderer which
 // lives inside the render process and provide access to audio hardware. It maps
 // an internal ID to AudioRendererHost::IPCAudioSource in a map, which is the
 // actual object providing audio packets through IPC. It creates the actual
 // AudioOutputStream object when requested by the renderer provided with
 // render view id and stream id.
@@ skipping 18 matching lines @@
 // which essentially post a task of OnDestroyed() on IO thread. Inside
 // OnDestroyed(), audio output streams are destroyed and Release() is called
 // which may result in self-destruction.
 
 #ifndef CHROME_BROWSER_RENDERER_HOST_AUDIO_RENDERER_HOST_H_
 #define CHROME_BROWSER_RENDERER_HOST_AUDIO_RENDERER_HOST_H_
 
 #include <map>
 #include <deque>
 
+#include "base/lock.h"
 #include "base/process.h"
 #include "base/ref_counted.h"
 #include "base/shared_memory.h"
 #include "base/waitable_event.h"
 #include "chrome/common/ipc_message.h"
 #include "media/audio/audio_output.h"
 
 class AudioManager;
-class Lock;
 class MessageLoop;
 struct ViewHostMsg_Audio_CreateStream;
 
 class AudioRendererHost : public base::RefCountedThreadSafe<AudioRendererHost> {
  private:
   class IPCAudioSource;
   friend class AudioRendererHost::IPCAudioSource;
  public:
   // Called from UI thread from the owner of this object.
   explicit AudioRendererHost(MessageLoop* message_loop);
@@ skipping 108 matching lines @@
   // A helper method for calling OnDestroySource on IO thread.
   void DestroySource(IPCAudioSource* source);
 
   MessageLoop* io_loop() { return io_loop_; }
 
   // The container for AudioOutputStream and serves audio packet for it by IPC.
   // This class does nothing more than sending IPC when OnMoreData is called
   // or error is received from the hardware audio thread, it also serves the
   // purpose of containing the audio output stream and associated information.
   // Lifetime of the audio output stream is not controlled by this class.
   class IPCAudioSource : public AudioOutputStream::AudioSourceCallback {

[M-A Ruel, 2009/06/03 14:28:37]

If you want to be zealous, move this class to audio_renderer_host.cc since it's
private anyway and would reduce the file dependencies.

    public:
     // Factory method for creating an IPCAudioSource, returns NULL if failed.
     static IPCAudioSource* CreateIPCAudioSource(
         AudioRendererHost* host,             // Host of this source.
         int process_id,                      // Process ID of renderer.
         int route_id,                        // Routing ID to RenderView.
         int stream_id,                       // ID of this source.
         base::ProcessHandle process_handle,  // Process handle of renderer.
         AudioManager::Format format,         // Format of the stream.
         int channels,                        // Number of channels.
@@ skipping 75 matching lines @@
   typedef std::pair<int32, int32> SourceID;
   typedef std::map<SourceID, IPCAudioSource*> SourceMap;
   SourceMap sources_;
 
   MessageLoop* io_loop_;
 
   DISALLOW_COPY_AND_ASSIGN(AudioRendererHost);
 };
 
 #endif  // CHROME_BROWSER_RENDERER_HOST_AUDIO_RENDERER_HOST_H_