Reduce header dependencies in base/

Reduce header dependencies in base/

Also adds more explicit #includes for needed things.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17479

[M-A Ruel, 2009-06-03 14:28:37]

lgtm as-is with optional additions.

http://codereview.chromium.org/118162/diff/1/20
File base/system_monitor.h (right):

http://codereview.chromium.org/118162/diff/1/20#newcode32
Line 32: static SystemMonitor* Get() {
Humm I'd rather have this function implementation in system_monitor.cc. This
way, you can also remove singleton.h.

http://codereview.chromium.org/118162/diff/1/22
File base/tracked_objects.h (right):

http://codereview.chromium.org/118162/diff/1/22#newcode8
Line 8:
//------------------------------------------------------------------------------
Remove that useless waste of bytes.

http://codereview.chromium.org/118162/diff/1/28
File chrome/browser/renderer_host/audio_renderer_host.h (right):

http://codereview.chromium.org/118162/diff/1/28#newcode176
Line 176: class IPCAudioSource : public AudioOutputStream::AudioSourceCallback {
If you want to be zealous, move this class to audio_renderer_host.cc since it's
private anyway and would reduce the file dependencies.

[Paweł Hajdan Jr., 2009-06-03 15:20:25]

On 2009/06/03 14:28:37, M-A wrote:
> lgtm as-is with optional additions.
> 
> http://codereview.chromium.org/118162/diff/1/20
> File base/system_monitor.h (right):
> 
> http://codereview.chromium.org/118162/diff/1/20#newcode32
> Line 32: static SystemMonitor* Get() {
> Humm I'd rather have this function implementation in system_monitor.cc. This
> way, you can also remove singleton.h.

I got some linking problems on Windows after this change. Not applied as a
result.

> http://codereview.chromium.org/118162/diff/1/22
> File base/tracked_objects.h (right):
> 
> http://codereview.chromium.org/118162/diff/1/22#newcode8
> Line 8:
>
//------------------------------------------------------------------------------
> Remove that useless waste of bytes.

Done.

> http://codereview.chromium.org/118162/diff/1/28
> File chrome/browser/renderer_host/audio_renderer_host.h (right):
> 
> http://codereview.chromium.org/118162/diff/1/28#newcode176
> Line 176: class IPCAudioSource : public AudioOutputStream::AudioSourceCallback
{
> If you want to be zealous, move this class to audio_renderer_host.cc since
it's
> private anyway and would reduce the file dependencies.

Not applied. I'm afraid it would require one more pass of long trybot checking
etc... maybe I'll do it as a part of browser cleanup.

[Lei Zhang, 2009-06-03 18:34:36]

Thanks again for doing this. I've been working on massaging the header include
data from gcc -H into something that's easy to visualize and understand. When I
finish you can see the effect from these patches.