Issue 118157: Refactor IA32 shift operations to simplify moving the right operand...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 118157: Refactor IA32 shift operations to simplify moving the right operand... (Closed)

Created:
11 years, 6 months ago by Kevin Millikin (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
William Hesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Refactor IA32 shift operations to simplify moving the right operand into the ecx register and to ensure that there is no frame effect between the first entry to the deferred code and binding its exit. Committed: http://code.google.com/p/v8/source/detail?r=2096

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+91 lines, -109 lines)			Patch
	M	src/ia32/codegen-ia32.cc	View	1	4 chunks	+91 lines, -109 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

William Hesse

11 years, 6 months ago (2009-06-03 12:12:04 UTC) #2

LGTM.  1 grammar fix.

http://codereview.chromium.org/118157/diff/1001/1002
File src/ia32/codegen-ia32.cc (right):

http://codereview.chromium.org/118157/diff/1001/1002#newcode1194
Line 1194: // Smi tagging these two cases can only happen with shifts
// Smi tagging.  These two cases can..

Expand Messages | Collapse Messages