Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(968)

Issue 118150: Linux bookmark manager first cut. (Closed)

Created:
11 years, 6 months ago by Evan Stade
Modified:
9 years, 6 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Linux bookmark manager first cut. Also add icons to bookmark tree model. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17489

Patch Set 1 #

Patch Set 2 : lint fix #

Patch Set 3 : fixes and icons #

Patch Set 4 : 1 more file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+434 lines, -56 lines) Patch
M chrome/browser/bookmarks/bookmark_context_menu.cc View 1 2 8 chunks +11 lines, -18 lines 0 comments Download
A chrome/browser/bookmarks/bookmark_manager.h View 1 chunk +25 lines, -0 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_utils.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_utils.cc View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
chrome/browser/browser_prefs.cc View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/gtk/bookmark_bar_gtk.cc View 2 chunks +4 lines, -9 lines 0 comments Download
M chrome/browser/gtk/bookmark_editor_gtk.cc View 1 2 2 chunks +18 lines, -7 lines 0 comments Download
A chrome/browser/gtk/bookmark_manager_gtk.h View 1 1 chunk +79 lines, -0 lines 0 comments Download
A chrome/browser/gtk/bookmark_manager_gtk.cc View 1 2 1 chunk +212 lines, -0 lines 0 comments Download
M chrome/browser/gtk/bookmark_tree_model.h View 1 2 2 chunks +23 lines, -3 lines 0 comments Download
M chrome/browser/gtk/bookmark_tree_model.cc View 1 2 6 chunks +34 lines, -8 lines 0 comments Download
M chrome/browser/views/bookmark_manager_view.h View 1 2 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/views/bookmark_manager_view.cc View 1 2 4 chunks +14 lines, -6 lines 0 comments Download
M chrome/chrome.gyp View 1 2 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Evan Stade
11 years, 6 months ago (2009-06-03 02:53:35 UTC) #1
Elliot Glaysher
11 years, 6 months ago (2009-06-03 17:14:09 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698