Issue 118126: Linux: stop libevent from pre-allocating huge arrays.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 118126: Linux: stop libevent from pre-allocating huge arrays. (Closed)

Created:
11 years, 6 months ago by agl

Modified:
9 years, 7 months ago

Reviewers:
dank

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Linux: stop libevent from pre-allocating huge arrays. Currently, libevent allocates two structures of size RLIMIT_NOFILE (which is 8192 on Ubuntu) and so these end up being several hundred kB of memory for each MessageLoopIO. This patch changes the default size to 32. If the thread watches a file descriptor greater than 32, the arrays will be grown as needed, doubling each time.

Patch Set 1 #

Created: 11 years, 6 months ago

		Unified diffs	Side-by-side diffs	Stats (+2 lines, -12 lines)
	M	third_party/libevent/epoll.c	View	3 chunks	+2 lines, -12 lines	0 comments

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

dank

11 years, 6 months ago (2009-06-02 20:16:08 UTC) #2

The description should mention the bug fix and link to the bug report you're
filing.
It should also mention that it's not upstream-quality because it strips
the solaris kludge.  (Maybe you could keep the solaris kludge by doing
a min rather than an =, and send this upstream?)

32 is so low that Chrome will reallocate that array quickly.
In fact, even browsing with
  ulimit -n 100
Chrome crashes pretty quickly.   ulimit -n 200 didn't crash in the ten
minutes I tried.  I suppose that doesn't matter, though.

Otherwise LGTM

Expand Messages | Collapse Messages