DevTools Profiler UI changes....

webkit/glue/devtools/js/profiler_processor.js

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview Profiler processor is used to process log file produced
  * by V8 and produce an internal profile representation which is used
  * for building profile views in 'Profiles' tab.
  */
 goog.provide('devtools.profiler.Processor');
 
 
 /**
  * Ancestor of a profile object that leaves out only JS-related functions.
  * @constructor
  */
 devtools.profiler.JsProfile = function() {
   devtools.profiler.Profile.call(this);
 };
 goog.inherits(devtools.profiler.JsProfile, devtools.profiler.Profile);
 
 
 /**
+ * RegExp that leaves only JS functions.
  * @type {RegExp}
  */
 devtools.profiler.JsProfile.JS_FUNC_RE = /^(LazyCompile|Function|Script):/;
 
+/**
+ * RegExp that filters out native code (ending with "native src.js:xxx").
+ * @type {RegExp}
+ */
+devtools.profiler.JsProfile.JS_NATIVE_FUNC_RE = /\ native\ \w+\.js:\d+$/;
+
+/**
+ * RegExp that filters out native scripts.
+ * @type {RegExp}
+ */
+devtools.profiler.JsProfile.JS_NATIVE_SCRIPT_RE = /^Script:\ native/;
+
 
 /**
  * @override
  */
 devtools.profiler.JsProfile.prototype.skipThisFunction = function(name) {
-  return !devtools.profiler.JsProfile.JS_FUNC_RE.test(name);
+  return !devtools.profiler.JsProfile.JS_FUNC_RE.test(name) ||
+      devtools.profiler.JsProfile.JS_NATIVE_FUNC_RE.test(name) ||

[pfeldman, 2009/06/02 11:30:24]

Could you hide this behind the flag / option at least for debugging purposes?
(I'd like to be able to investigate what natives eat ticks some time later).

[mnaganov (inactive), 2009/06/02 11:44:43]

Added a comment that you need to comment out these two lines in order to profile
natives.

+      devtools.profiler.JsProfile.JS_NATIVE_SCRIPT_RE.test(name);
 };
 
 
 /**
  * Profiler processor. Consumes profiler log and builds profile views.
  *
  * @param {function(devtools.profiler.ProfileView)} newProfileCallback Callback
  *     that receives a new processed profile.
  * @constructor
  */
 devtools.profiler.Processor = function(newProfileCallback) {
   /**
-   *
+   * Callback that adds a new profile to view.
+   * @type {function(devtools.profiler.ProfileView)}
    */
   this.newProfileCallback_ = newProfileCallback;
 
   /**
    * Profiles array.
    * @type {Array<devtools.profiler.JsProfile>}
    */
   this.profiles_ = [];
 
   /**
@@ skipping 34 matching lines @@
   // Not used in DevTools Profiler.
   'shared-library': null,
   // Obsolete row types.
   'code-allocate': null,
   'begin-code-region': null,
   'end-code-region': null
 };
 
 
 /**
+ * Sets new profile callback.
+ * @param {function(devtools.profiler.ProfileView)} callback Callback function.
+ */
+devtools.profiler.Processor.prototype.setNewProfileCallback = function(
+    callback) {
+  this.newProfileCallback_ = callback;
+};
+
+
+/**
  * Processes a portion of V8 profiler event log.
  *
  * @param {string} chunk A portion of log.
  */
 devtools.profiler.Processor.prototype.processLogChunk = function(chunk) {
   this.processLog_(chunk.split('\n'));
 };
 
 
 /**
@@ skipping 119 matching lines @@
   profile.title = UserInitiatedProfileName + '.' + profile.uid;
   // A trick to cope with ProfileView.bottomUpProfileDataGridTree and
   // ProfileView.topDownProfileDataGridTree behavior.
   profile.head = profile;
   profile.heavyProfile = this.viewBuilder_.buildView(
       this.currentProfile_.getBottomUpProfile(), true);
   profile.treeProfile = this.viewBuilder_.buildView(
       this.currentProfile_.getTopDownProfile());
   return profile;
 };