Issue 118112: DevTools Profiler UI changes....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 118112: DevTools Profiler UI changes.... (Closed)

Created:
11 years, 6 months ago by mnaganov (inactive)

Modified:
9 years, 7 months ago

Reviewers:
pfeldman

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

DevTools Profiler UI changes. - filter our V8 natives; - display a notification that profile is being processed to avoid confusion; - do not display ".000" part when displaying time. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17399

Patch Set 1 #

Total comments: 2

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+75 lines, -13 lines)			Patch
M	webkit/glue/devtools/js/debugger_agent.js	View	1 chunk	+16 lines, -0 lines	0 comments	Download
M	webkit/glue/devtools/js/devtools.js	View	9 chunks	+31 lines, -11 lines	0 comments	Download
M	webkit/glue/devtools/js/profiler_processor.js	View	3 chunks	+28 lines, -2 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

pfeldman

LGTM http://codereview.chromium.org/118112/diff/1/3 File webkit/glue/devtools/js/profiler_processor.js (right): http://codereview.chromium.org/118112/diff/1/3#newcode47 Line 47: devtools.profiler.JsProfile.JS_NATIVE_FUNC_RE.test(name) || Could you hide this behind ...

11 years, 6 months ago (2009-06-02 11:30:23 UTC) #2

mnaganov (inactive)

11 years, 6 months ago (2009-06-02 11:44:43 UTC) #3

http://codereview.chromium.org/118112/diff/1/3
File webkit/glue/devtools/js/profiler_processor.js (right):

http://codereview.chromium.org/118112/diff/1/3#newcode47
Line 47: devtools.profiler.JsProfile.JS_NATIVE_FUNC_RE.test(name) ||
On 2009/06/02 11:30:24, pfeldman wrote:
> Could you hide this behind the flag / option at least for debugging purposes?
> (I'd like to be able to investigate what natives eat ticks some time later).

Added a comment that you need to comment out these two lines in order to profile
natives.

Expand Messages | Collapse Messages