Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 118110: Factor out the code for emitting the IA32 binary operations div and... (Closed)

Created:
11 years, 6 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
Reviewers:
William Hesse
CC:
v8-dev
Visibility:
Public.

Description

Factor out the code for emitting the IA32 binary operations div and mod so they do not share code with the other binary operations. They now preallocate their fixed registers (eax and edx). There is now no frame effect between entries to the deferred call to the stub. Committed: http://code.google.com/p/v8/source/detail?r=2087

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -161 lines) Patch
M src/ia32/codegen-ia32.cc View 5 chunks +152 lines, -161 lines 2 comments Download

Messages

Total messages: 3 (0 generated)
Kevin Millikin (Chromium)
11 years, 6 months ago (2009-06-02 08:49:04 UTC) #1
William Hesse
LGTM. http://codereview.chromium.org/118110/diff/1/2 File src/ia32/codegen-ia32.cc (right): http://codereview.chromium.org/118110/diff/1/2#newcode5778 Line 5778: if (!(remainder.is_register() && remainder.reg().is(edx))) { remainder is ...
11 years, 6 months ago (2009-06-02 09:11:54 UTC) #2
Kevin Millikin (Chromium)
11 years, 6 months ago (2009-06-02 10:36:59 UTC) #3
http://codereview.chromium.org/118110/diff/1/2
File src/ia32/codegen-ia32.cc (right):

http://codereview.chromium.org/118110/diff/1/2#newcode5778
Line 5778: if (!(remainder.is_register() && remainder.reg().is(edx))) {
Thanks.  I've changed it to !remainder.is_valid() which reads much better.

Powered by Google App Engine
This is Rietveld 408576698