Issue 118102: Fixes a couple of bugs encountered in getting info bubbles to work:...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 118102: Fixes a couple of bugs encountered in getting info bubbles to work:... (Closed)

Created:
11 years, 6 months ago by sky

Modified:
9 years, 7 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fixes a couple of bugs encountered in getting info bubbles to work: . Initial bounds of windows weren't being set. . Widgets were created initially shown. This was bad for windows as the window would end up showing prematurely. . WindowGtk::window_state_ wasn't being initialized. . And then actual InfoBubble stuff: properly init the bubble, show it and position it on the monitor. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17401

Patch Set 1 #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -12 lines)			Patch
M	chrome/browser/views/info_bubble.cc	View	6 chunks	+8 lines, -10 lines	0 comments	Download
M	views/widget/widget_gtk.cc	View	2 chunks	+4 lines, -1 line	0 comments	Download
M	views/window/window_gtk.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	views/window/window_gtk.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

OK

Expand Messages | Collapse Messages