Issue 1181001: Add comments to test-log-stack-tracer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1181001: Add comments to test-log-stack-tracer. (Closed)

Created:
10 years, 9 months ago by mnaganov (inactive)

Modified:
9 years, 7 months ago

Reviewers:
iposva

CC:
v8-dev

Visibility:
Public.

Description

Add comments to test-log-stack-tracer. Committed: http://code.google.com/p/v8/source/detail?r=4240

Patch Set 1 #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -2 lines)			Patch
	M	test/cctest/test-log-stack-tracer.cc	View		5 chunks	+35 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

mnaganov (inactive)

On 2010/03/23 18:16:13, Michail Naganov wrote: > Ivan, please look if it makes more sense ...

10 years, 9 months ago (2010-03-23 18:16:52 UTC) #2

iposva

LGTM Still convoluted but much better and easier to follow. I guess the complicated dance ...

10 years, 9 months ago (2010-03-23 18:39:25 UTC) #3

mnaganov (inactive)

10 years, 9 months ago (2010-03-24 08:45:48 UTC) #4

On 2010/03/23 18:39:25, iposva wrote:
> LGTM
> 
> Still convoluted but much better and easier to follow. I guess the complicated
> dance comes with the territory...
> 
> -Ivan

Thanks!

This night I had an idea how I can try to simplify the test. I will check it out
today.

Expand Messages | Collapse Messages