Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Side by Side Diff: net/base/tcp_client_socket_unittest.cc

Issue 118100: Avoid doing concurrent DNS resolves of the same hostname (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Get compiling on mac Created 11 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/base/tcp_client_socket.h" 5 #include "net/base/tcp_client_socket.h"
6 6
7 #include "base/basictypes.h" 7 #include "base/basictypes.h"
8 #include "net/base/address_list.h" 8 #include "net/base/address_list.h"
9 #include "net/base/host_resolver.h" 9 #include "net/base/host_resolver.h"
10 #include "net/base/io_buffer.h" 10 #include "net/base/io_buffer.h"
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
80 sock = ListenSocket::Listen("127.0.0.1", port, this); 80 sock = ListenSocket::Listen("127.0.0.1", port, this);
81 if (sock) 81 if (sock)
82 break; 82 break;
83 } 83 }
84 ASSERT_TRUE(sock != NULL); 84 ASSERT_TRUE(sock != NULL);
85 listen_sock_ = sock; 85 listen_sock_ = sock;
86 listen_port_ = port; 86 listen_port_ = port;
87 87
88 AddressList addr; 88 AddressList addr;
89 HostResolver resolver; 89 HostResolver resolver;
90 int rv = resolver.Resolve("localhost", listen_port_, &addr, NULL); 90 int rv = resolver.Resolve("localhost", listen_port_, &addr, NULL, NULL);
91 CHECK(rv == OK); 91 CHECK(rv == OK);
92 sock_.reset(new TCPClientSocket(addr)); 92 sock_.reset(new TCPClientSocket(addr));
93 } 93 }
94 94
95 TEST_F(TCPClientSocketTest, Connect) { 95 TEST_F(TCPClientSocketTest, Connect) {
96 TestCompletionCallback callback; 96 TestCompletionCallback callback;
97 EXPECT_FALSE(sock_->IsConnected()); 97 EXPECT_FALSE(sock_->IsConnected());
98 98
99 int rv = sock_->Connect(&callback); 99 int rv = sock_->Connect(&callback);
100 if (rv != OK) { 100 if (rv != OK) {
(...skipping 228 matching lines...) Expand 10 before | Expand all | Expand 10 after
329 // Close the server socket, so there will at least be a 0-byte read. 329 // Close the server socket, so there will at least be a 0-byte read.
330 CloseServerSocket(); 330 CloseServerSocket();
331 331
332 rv = callback.WaitForResult(); 332 rv = callback.WaitForResult();
333 EXPECT_GE(rv, 0); 333 EXPECT_GE(rv, 0);
334 } 334 }
335 335
336 } // namespace 336 } // namespace
337 337
338 } // namespace net 338 } // namespace net
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698