Issue 11810: Adjust histograms to get better data for latency experiments...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11810: Adjust histograms to get better data for latency experiments... (Closed)

Created:
12 years, 1 month ago by jar (doing other things)

Modified:
9 years, 7 months ago

Reviewers:
huanr, Lincoln, wtc

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Adjust histograms to get better data for latency experiments r=openvcdiff,huanr Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=5891

Patch Set 3 : '' #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -27 lines)			Patch
M	base/histogram.h	View		2 chunks	+8 lines, -1 line	1 comment	Download
M	net/base/filter.cc	View	1 2	2 chunks	+16 lines, -2 lines	0 comments	Download
M	net/base/sdch_filter.cc	View		1 chunk	+4 lines, -3 lines	0 comments	Download
M	net/base/sdch_manager.h	View		2 chunks	+28 lines, -20 lines	1 comment	Download
M	net/base/sdch_manager.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

wtc

LGTM. With one nit. http://codereview.chromium.org/11810/diff/201/404 File net/base/filter.cc (right): http://codereview.chromium.org/11810/diff/201/404#newcode97 Line 97: // Multiple filters was ...

12 years, 1 month ago (2008-11-22 01:38:50 UTC) #2

Lincoln

LGTM http://codereview.chromium.org/11810/diff/409/206 File base/histogram.h (right): http://codereview.chromium.org/11810/diff/409/206#newcode105 Line 105: #define UMA_HISTOGRAM_TIMES(name, sample) do { \ If ...

12 years, 1 month ago (2008-11-24 17:31:41 UTC) #3

LGTM

Expand Messages | Collapse Messages

Issue 11810: Adjust histograms to get better data for latency experiments... (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages