Issue 118097: Make bookmark bar more amenable to dark themes....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 118097: Make bookmark bar more amenable to dark themes.... (Closed)

Created:
11 years, 6 months ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
Elliot Glaysher

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Make bookmark bar more amenable to dark themes. - Explicitly set button text color. - Set background of drag widget. BUG=none TEST=use a dark system theme, make sure everything looks reasonable. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17374

Patch Set 1 #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -0 lines)			Patch
	M	chrome/browser/gtk/bookmark_bar_gtk.cc	View		5 chunks	+40 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Elliot Glaysher

11 years, 6 months ago (2009-06-02 00:20:08 UTC) #2

On 2009/06/02 00:11:28, Evan Stade wrote:
> Q: what's the point of the gtkframe?

LGTM. (It's for drop shadows.)

Expand Messages | Collapse Messages