Issue 118096: Generate GUIDs for users who wish to upload crash reports. Include it in cra...

Issue 118096: Generate GUIDs for users who wish to upload crash reports. Include it in cra... (Closed)

Created:
11 years, 6 months ago by Lei Zhang

Modified:
9 years, 7 months ago

Reviewers:
agl

CC:
chromium-reviews_googlegroups.com, Evan Martin

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Generate GUIDs for users who wish to upload crash reports. Include it in crash reports. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17372

Patch Set 3 : '' #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+89 lines, -22 lines)			Patch
M	chrome/app/breakpad_linux.h	View	1 2	1 chunk	+5 lines, -2 lines	0 comments	Download
M	chrome/app/breakpad_linux.cc	View	1 2	8 chunks	+48 lines, -10 lines	0 comments	Download
M	chrome/browser/google_update_settings_linux.cc	View	1 2	2 chunks	+25 lines, -4 lines	0 comments	Download
M	chrome/browser/renderer_host/render_crash_handler_host_linux.cc	View	1 2	3 chunks	+11 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

http://codereview.chromium.org/118096/diff/1002/1004 File chrome/app/breakpad_linux.cc (right): http://codereview.chromium.org/118096/diff/1002/1004#newcode369 Line 369: sys_write(2, id_buf, my_strlen(id_buf)); Why am I still getting ...

11 years, 6 months ago (2009-06-01 23:58:43 UTC) #1

agl

LGTM with a couple of nits. http://codereview.chromium.org/118096/diff/1002/1004 File chrome/app/breakpad_linux.cc (right): http://codereview.chromium.org/118096/diff/1002/1004#newcode428 Line 428: UploadCrashDump(path, NULL, ...

11 years, 6 months ago (2009-06-02 00:09:18 UTC) #2

Lei Zhang

11 years, 6 months ago (2009-06-02 00:35:29 UTC) #3

http://codereview.chromium.org/118096/diff/1002/1004
File chrome/app/breakpad_linux.cc (right):

http://codereview.chromium.org/118096/diff/1002/1004#newcode428
Line 428: UploadCrashDump(path, NULL, 0, google_update::linux_guid.c_str(),
On 2009/06/02 00:09:18, agl wrote:
> This happens to rely on the libstdc++ implementation of std::string which
> doesn't allocate in .c_str(). Maybe you can use .data() here since you're
> already passing in the length?

Done.

http://codereview.chromium.org/118096/diff/1002/1006
File chrome/browser/renderer_host/render_crash_handler_host_linux.cc (right):

http://codereview.chromium.org/118096/diff/1002/1006#newcode88
Line 88: char context[kCrashContextSize + kMaxActiveURLSize];
On 2009/06/02 00:09:18, agl wrote:
> + 32?

Err, right.

Expand Messages | Collapse Messages