Issue 118095: Display a tooltip when mousing over a tab title.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 118095: Display a tooltip when mousing over a tab title. (Closed)

Created:
11 years, 6 months ago by jeremy

Modified:
9 years, 6 months ago

Reviewers:
John Grabowski

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Display a tooltip when mousing over a tab title. This allows a user to see the full page title. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17429

Patch Set 1 #

Patch Set 2 : now with unit test goodness #

Total comments: 1

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -0 lines)			Patch
M	chrome/browser/cocoa/tab_controller.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/cocoa/tab_controller.mm	View	1	2 chunks	+9 lines, -0 lines	0 comments	Download
M	chrome/browser/cocoa/tab_controller_unittest.mm	View		1 chunk	+13 lines, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

John Grabowski

LGTM but consider adding unit tests even for CLs as small as this.

11 years, 6 months ago (2009-06-01 23:41:34 UTC) #2

John Grabowski

11 years, 6 months ago (2009-06-02 00:10:51 UTC) #3

LGTM++

http://codereview.chromium.org/118095/diff/5/8
File chrome/browser/cocoa/tab_controller_unittest.mm (right):

http://codereview.chromium.org/118095/diff/5/8#newcode110
Line 110: // Tests that setting the title of a tab sets the tooltip as well.
u de man jeremy.

Expand Messages | Collapse Messages