Issue 118092: Fix appearance of dangerous download dialog....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 118092: Fix appearance of dangerous download dialog.... (Closed)

Created:
11 years, 6 months ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
Elliot Glaysher

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Linux: Fix appearance of dangerous download dialog. Don't give dangerous download dialog its own GdkWindow. We need the window to be transparent, which only works with compositing window managers, so instead of going through that hassle just don't give it a window. Let the text field adjust in size during animation. BUG=none TEST=download an .exe with a dark system theme. The dialog shouldn't have a dark frame around it. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17366

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -7 lines)			Patch
	M	chrome/browser/gtk/download_item_gtk.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	chrome/browser/gtk/download_item_gtk.cc	View	1	3 chunks	+15 lines, -7 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Could have sworn I reviewed this before. LGTM.

Expand Messages | Collapse Messages