Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1200)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/common/zip_unittest.cc

Issue 118087: Broaden valgrind supression for known issue in zlib. This seems (Closed)
Patch Set: Reenable zip tests on mac Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/valgrind/suppressions.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/zip_unittest.cc
diff --git a/chrome/common/zip_unittest.cc b/chrome/common/zip_unittest.cc
index 67dd48791da3c3a39474ebf563d936faeb206ade..17ab1faaa694d8f767895f6f86c3ce7ff013db43 100644
--- a/chrome/common/zip_unittest.cc
+++ b/chrome/common/zip_unittest.cc
@@ -75,9 +75,7 @@ class ZipTest : public PlatformTest {
// hard-coded contents of a known zip file
std::set<FilePath> zip_contents_;
};
-// TODO(aa): re-enable this test for Mac (was disabled temporarily to clear
-// valgrind error on mac.
-#if !defined(OS_MACOSX)
+
TEST_F(ZipTest, Unzip) {
TestUnzipFile(FILE_PATH_LITERAL("test.zip"));
}
@@ -103,5 +101,5 @@ TEST_F(ZipTest, Zip) {
EXPECT_TRUE(file_util::Delete(zip_file, false));
}
-#endif // !defined(OS_MACOSX)
+
} // namespace
« no previous file with comments | « no previous file | tools/valgrind/suppressions.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698