Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Unified Diff: base/pickle.cc

Issue 118085: Moved bug to external tracker. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/pickle.cc
===================================================================
--- base/pickle.cc (revision 17314)
+++ base/pickle.cc (working copy)
@@ -96,8 +96,8 @@
if (!IteratorHasRoomFor(*iter, sizeof(*result)))
return false;
- // TODO(jar) bug 1129285: Pickle should be cleaned up, and not dependent on
- // alignment.
+ // TODO(jar): http://crbug.com/13108 Pickle should be cleaned up, and not
+ // dependent on alignment.
// Next line is otherwise the same as: memcpy(result, *iter, sizeof(*result));
*result = *reinterpret_cast<int*>(*iter);
@@ -113,8 +113,8 @@
if (!IteratorHasRoomFor(*iter, sizeof(*result)))
return false;
- // TODO(jar) bug 1129285: Pickle should be cleaned up, and not dependent on
- // alignment.
+ // TODO(jar): http://crbug.com/13108 Pickle should be cleaned up, and not
+ // dependent on alignment.
memcpy(result, *iter, sizeof(*result));
UpdateIter(iter, sizeof(*result));
@@ -135,8 +135,8 @@
if (!IteratorHasRoomFor(*iter, sizeof(*result)))
return false;
- // TODO(jar) bug 1129285: Pickle should be cleaned up, and not dependent on
- // alignment.
+ // TODO(jar): http://crbug.com/13108 Pickle should be cleaned up, and not
+ // dependent on alignment.
// Next line is otherwise the same as: memcpy(result, *iter, sizeof(*result));
*result = *reinterpret_cast<size_t*>(*iter);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698