Fix opaque app mode display....

Fix opaque app mode display.

Changed the app corner images to be the same size as the center image.

BUG=12541
TEST=In an opaque app-frame window, verify that the top edge doesn't have a frame-colored space between the drop shadow and the content area.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17378

[Peter Kasting, 2009-06-01 01:28:18]

http://codereview.chromium.org/118058/diff/8/11
File chrome/browser/views/frame/opaque_browser_frame_view.cc (right):

http://codereview.chromium.org/118058/diff/8/11#newcode762
Line 762: SkColor toolbar_color =
tp->GetColor(BrowserThemeProvider::COLOR_TOOLBAR);
Nit: I wouldn't add whitespace above and below this

http://codereview.chromium.org/118058/diff/8/11#newcode778
Line 778: client_area_top = std::min(client_area_top,
I don't really understand this calculation... maybe you can explain it to me in
person.

http://codereview.chromium.org/118058/diff/8/11#newcode794
Line 794: client_area_bounds.right() + kClientEdgeThickness,
Nit: Doesn't this need to be "... + 1" since DrawLineInt() draws "up to but not
including" the last pixel?

[Finnur, 2009-06-01 01:38:32]

drive-by-nit...

http://codereview.chromium.org/118058/diff/8/11
File chrome/browser/views/frame/opaque_browser_frame_view.cc (right):

http://codereview.chromium.org/118058/diff/8/11#newcode778
Line 778: client_area_top = std::min(client_area_top,
... or better yet, comment it so that the next person scratching his/her head
won't also have to come to you for a tutorial. :)

On 2009/06/01 01:28:18, pkasting wrote:
> I don't really understand this calculation... maybe you can explain it to me
in
> person.

[Glen Murphy, 2009-06-02 01:06:22]

Reuploaded:

I got rid of the calculation, as I didn't write it, couldn't find a reason for
it, and removing it hasn't caused any issues, even at tiny sizes.

> Nit: Doesn't this need to be "... + 1" since DrawLineInt() 
> draws "up > to but not including" the last pixel?

It's actually - 1 + 1 (see the right side edge drawing code below).

[Peter Kasting, 2009-06-02 02:02:58]

On 2009/06/02 01:06:22, Glen Murphy wrote:
> Reuploaded:
> 
> I got rid of the calculation, as I didn't write it, couldn't find a reason for
> it, and removing it hasn't caused any issues, even at tiny sizes.

I remember why I added it now.  I think it can't reproduce anymore on the opaque
frame since I've added a minimum window size; not sure about the glass frame,
but it's not that important as I'll eventually fix that too.

> > Nit: Doesn't this need to be "... + 1" since DrawLineInt() 
> > draws "up > to but not including" the last pixel?
> 
> It's actually - 1 + 1 (see the right side edge drawing code below).

Ah yes, I forgot that right() was already one-past-the-end.

LGTM.