Parsing routines for X-Force-TLS header....

net/base/force_tls_state.h

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_BASE_FORCE_TLS_STATE_H_
 #define NET_BASE_FORCE_TLS_STATE_H_
 
 #include <set>
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/lock.h"
 
 class GURL;
 
 namespace net {
 
 // ForceTLSState
 //
 // Tracks which hosts have enabled ForceTLS.  After a host enables ForceTLS,
 // then we refuse to talk to the host over HTTP, treat all certificate errors as
 // fatal, and refuses to load any mixed content.

[wtc, 2009/06/01 17:59:19]

Nit: refuses => refuse

[abarth-chromium, 2009/06/02 02:24:05]

Fixed.

 //
 class ForceTLSState {
  public:
   ForceTLSState();
 
   // Called when we see an X-Force-TLS header that we should process.  Modifies
   // our state as instructed by the header.
   void DidReceiveHeader(const GURL& url, const std::string& value);
 
   // Enable ForceTLS for |host|.
   void EnableHost(const std::string& host);
 
   // Returns whether |host| has had ForceTLS enabled.
   bool IsEnabledForHost(const std::string& host);
 
+  // Returns |true| if value parses as a valid X-Force-TLS header value.

[wtc, 2009/06/01 17:59:19]

Nit: the first "value" should be quoted with ||.

[abarth-chromium, 2009/06/02 02:24:05]

Fixed.

+  // The value of max-age and and includeSubDomains are returned in |max_age|

[wtc, 2009/06/01 17:59:19]

Nit: value => values

Could you include the definition of the X-Force-TLS header
in this comment, or cite a reference that defines the header?

[abarth-chromium, 2009/06/02 02:24:05]

Fixed.
The spec is still under development.  This is an experimental implemenation
(behind a command line flag) that's meant to help the spec writers figure out
how the spec should work.  I'll add a link once there is something published to
refer to.

+  // and |include_subdomains|, respectively.  The out parameters are not
+  // modified if the function returns |false|.
+  static bool ParseHeader(const std::string& value,
+                          int* max_age,
+                          bool* include_subdomains);
+
  private:
   // The set of hosts that have enabled ForceTLS.
   std::set<std::string> enabled_hosts_;
 
   // Protect access to our data members with this lock.
   Lock lock_;
 
   DISALLOW_COPY_AND_ASSIGN(ForceTLSState);
 };
 
 }  // namespace net
 
 #endif  // NET_BASE_FORCE_TLS_STATE_H_