Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 118039: Implement SSL client authentication for Windows.... (Closed)

Created:
11 years, 6 months ago by wtc
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Specify new methods for supporting SSL client authentication. See the changes to url_request.h and ssl_cert_request_info.h. They are similar to the methods for handling SSL certificate errors and HTTP authentication. The handling of servers that request but don't require SSL client authentication is reimplemented using the new methods. R=rvargas,eroman BUG=http://crbug.com/318 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18322

Patch Set 1 #

Patch Set 2 : Week 2 snapshot #

Patch Set 3 : Just a snapshot #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : Minor fixes afer self review #

Patch Set 7 : Don't try to guess error code #

Total comments: 3

Patch Set 8 : Upload before checkin #

Patch Set 9 : Upload before checkin #

Unified diffs Side-by-side diffs Delta from patch set Stats (+282 lines, -60 lines) Patch
M net/base/net_error_list.h View 4 5 6 7 8 1 chunk +3 lines, -0 lines 0 comments Download
M net/base/socket_test_util.cc View 2 3 4 5 6 7 8 2 chunks +7 lines, -0 lines 0 comments Download
A net/base/ssl_cert_request_info.h View 2 3 1 chunk +37 lines, -0 lines 0 comments Download
M net/base/ssl_client_socket.h View 2 3 4 5 6 7 8 3 chunks +7 lines, -1 line 0 comments Download
M net/base/ssl_client_socket_mac.h View 4 5 6 7 8 2 chunks +2 lines, -1 line 0 comments Download
M net/base/ssl_client_socket_mac.cc View 4 5 6 7 8 3 chunks +6 lines, -2 lines 0 comments Download
M net/base/ssl_client_socket_nss.h View 4 5 6 7 8 2 chunks +2 lines, -1 line 0 comments Download
M net/base/ssl_client_socket_nss.cc View 4 5 6 7 8 2 chunks +6 lines, -1 line 0 comments Download
M net/base/ssl_client_socket_win.h View 1 2 3 4 5 6 7 8 3 chunks +2 lines, -4 lines 0 comments Download
M net/base/ssl_client_socket_win.cc View 1 2 3 4 5 6 7 8 7 chunks +18 lines, -28 lines 0 comments Download
M net/base/ssl_config_service.h View 2 3 4 5 6 7 8 3 chunks +10 lines, -2 lines 0 comments Download
M net/http/http_cache.cc View 2 3 4 5 6 7 8 7 chunks +44 lines, -1 line 0 comments Download
M net/http/http_network_transaction.h View 2 3 4 5 6 7 8 3 chunks +6 lines, -1 line 0 comments Download
M net/http/http_network_transaction.cc View 2 3 4 5 6 7 8 7 chunks +46 lines, -9 lines 0 comments Download
M net/http/http_response_info.h View 2 3 4 5 6 7 8 3 chunks +8 lines, -1 line 0 comments Download
M net/http/http_response_info.cc View 2 3 4 5 6 7 8 1 chunk +2 lines, -0 lines 0 comments Download
M net/http/http_transaction.h View 2 3 4 5 6 7 8 3 chunks +6 lines, -1 line 0 comments Download
M net/http/http_transaction_unittest.h View 2 3 4 5 6 7 8 2 chunks +6 lines, -1 line 0 comments Download
M net/net.gyp View 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
M net/url_request/url_request.h View 1 2 3 4 5 6 7 8 4 chunks +18 lines, -1 line 0 comments Download
M net/url_request/url_request.cc View 2 3 4 5 6 7 8 2 chunks +7 lines, -1 line 0 comments Download
M net/url_request/url_request_http_job.h View 2 3 4 5 6 7 8 2 chunks +2 lines, -1 line 0 comments Download
M net/url_request/url_request_http_job.cc View 2 3 4 5 6 7 8 4 chunks +25 lines, -1 line 0 comments Download
M net/url_request/url_request_job.h View 2 3 4 5 6 7 8 3 chunks +4 lines, -1 line 0 comments Download
M net/url_request/url_request_job.cc View 2 3 4 5 6 7 8 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
wtc
Ricardo, please review the whole thing. This CL is not as big as it looks. ...
11 years, 6 months ago (2009-06-12 03:21:37 UTC) #1
jcampan
LGTM for my part.
11 years, 6 months ago (2009-06-12 16:43:10 UTC) #2
wtc
You can review the CL in this order. 1. url_request.h and ssl_cert_request_info.h This is the ...
11 years, 6 months ago (2009-06-12 17:21:29 UTC) #3
rvargas (doing something else)
11 years, 6 months ago (2009-06-12 21:20:00 UTC) #4
Nice Job. LGTM.

You may want to update the copyright notice.

http://codereview.chromium.org/118039/diff/3096/3101
File net/http/http_network_transaction.h (right):

http://codereview.chromium.org/118039/diff/3096/3101#newcode166
Line 166: void HandleCertificateRequest();
Nit: Maybe HandleClientCertificateRequest() is a better name.

http://codereview.chromium.org/118039/diff/3096/3105
File net/http/http_response_info.h (right):

http://codereview.chromium.org/118039/diff/3096/3105#newcode48
Line 48: // challenge, client certificate request is not part of an HTTP
response.
Maybe we can to add another method to HttpTranaction to get this info and let
the transaction itself store it. I'm just thinking out loud (no need to change
this now)

http://codereview.chromium.org/118039/diff/3096/3097
File net/url_request/url_request.h (right):

http://codereview.chromium.org/118039/diff/3096/3097#newcode108
Line 108: // The callbacks will be called in the following order:
nit: We should include the SSL callbacks here.

Powered by Google App Engine
This is Rietveld 408576698