Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Unified Diff: build/mac/tweak_app_infoplist

Issue 118036: Tweak SVNVersion be happier (matches windows).... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/file_version_info_mac.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/mac/tweak_app_infoplist
===================================================================
--- build/mac/tweak_app_infoplist (revision 17147)
+++ build/mac/tweak_app_infoplist (working copy)
@@ -65,12 +65,10 @@
APP_NAME=$("${BRAND_SCRIPT}" "${BUILD_BRANDING}" PRODUCT_FULLNAME)
SRC_APP_PATH="${BUILT_PRODUCTS_DIR}/${APP_NAME}.app"
-# Figure out what version this build corresponds to. Just use the svn revision
-# for now. Warning: my svnversion returns 10495:10552M. But that's ok since
-# it is just for reference.
-SVN_REVISION=$(svnversion "${SRCROOT}")
+# Visible in the about:version page.
+SVN_REVISION=$(svn info "${SRCROOT}" | grep "Revision:" | cut -d" " -f2-)
if [ -z "${SVN_REVISION}" ] ; then
jeremy 2009/06/01 18:15:06 Could you add a comment about needing to add a cod
- echo "warning: could not determine svn revision" >&2
+ echo "Could not determine svn revision. This may be OK." >&2
fi
# Pull in the chrome version number
@@ -94,8 +92,10 @@
cp "${SRC_APP_PATH}/${INFO_PLIST_PATH}" "${TMP_INFO_PLIST}"
# Save off the svn version number in case we need it
-defaults write "${TMP_INFO_PLIST_DEFAULTS}" \
+if [ ! -z "${SVN_REVISION}" ] ; then
+ defaults write "${TMP_INFO_PLIST_DEFAULTS}" \
SVNRevision -string "${SVN_REVISION}"
+fi
# Add public version info so "Get Info" works
defaults write "${TMP_INFO_PLIST_DEFAULTS}" \
« no previous file with comments | « base/file_version_info_mac.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698