Tweak SVNVersion be happier (matches windows)....

Tweak SVNVersion be happier (matches windows).

Fix about:version so "Developer build" says "Official build" when
relevant, and lists SVN version for developer builds.

BUG=12064
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17337

[TVL, 2009-05-29 23:24:43]

http://codereview.chromium.org/118036/diff/1/2
File build/mac/tweak_app_infoplist (right):

http://codereview.chromium.org/118036/diff/1/2#newcode70
Line 70: # it is just for reference.
drive by: comment should be changed.

[John Grabowski, 2009-05-30 00:37:30]

http://codereview.chromium.org/118036/diff/1/2
File build/mac/tweak_app_infoplist (right):

http://codereview.chromium.org/118036/diff/1/2#newcode70
Line 70: # it is just for reference.
On 2009/05/29 23:24:43, TVL wrote:
> drive by: comment should be changed.

Updated.

[jeremy, 2009-05-30 19:21:28]

http://codereview.chromium.org/118036/diff/2001/3001
File build/mac/tweak_app_infoplist (right):

http://codereview.chromium.org/118036/diff/2001/3001#newcode69
Line 69: SVN_REVISION=$(svn info "${SRCROOT}" | grep "Revision:" | cut -d" "
-f2-)
(I'm assuming this script is also run when creating a branded build from a
developer's machine).

Some people (such as me) checkout using git, could you add an if to check for
.svn here and exit if it isn't there exit with a warning message for now.
My concern is just having the build fail in a mysterious way and having to track
down the cause.
I'll fill in the git case in a future CL.

[John Grabowski, 2009-06-01 17:29:26]

http://codereview.chromium.org/118036/diff/2001/3001
File build/mac/tweak_app_infoplist (right):

http://codereview.chromium.org/118036/diff/2001/3001#newcode69
Line 69: SVN_REVISION=$(svn info "${SRCROOT}" | grep "Revision:" | cut -d" "
-f2-)
On 2009/05/30 19:21:28, jeremy wrote:
> (I'm assuming this script is also run when creating a branded build from a
> developer's machine).
> 
> Some people (such as me) checkout using git, could you add an if to check for
> .svn here and exit if it isn't there exit with a warning message for now.
> My concern is just having the build fail in a mysterious way and having to
track
> down the cause.
> I'll fill in the git case in a future CL.

Adapted to accomodate git (see lower).
New diff uploaded.

[jeremy, 2009-06-01 18:15:06]

LGTM

http://codereview.chromium.org/118036/diff/9/10
File build/mac/tweak_app_infoplist (right):

http://codereview.chromium.org/118036/diff/9/10#newcode70
Line 70: if [ -z "${SVN_REVISION}" ] ; then
Could you add a comment about needing to add a codepath for GIT?