Issue 118025: Fix a memory leak... the wrapped platform helper isn't a view, so it's not au...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 118025: Fix a memory leak... the wrapped platform helper isn't a view, so it's not au... (Closed)

Created:
11 years, 6 months ago by Ben Goodger (Google)

Modified:
9 years, 6 months ago

Reviewers:
brettw

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Fix a memory leak... the wrapped platform helper isn't a view, so it's not auto-deleted... use a scoped_ptr instead! BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17220

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -6 lines)			Patch
M	views/controls/native/native_view_host.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	views/controls/native/native_view_host.cc	View		4 chunks	+4 lines, -5 lines	0 comments	Download
M	views/controls/native/native_view_host_wrapper.h	View	2	1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

LGTM