Wrap MSVC-specific pragmas. As -Wunknown-pragmas has been disabled for wtf,...

Wrap MSVC-specific pragmas. As -Wunknown-pragmas has been disabled for wtf,
some of these sneaked in.

BUG=2053

[Dean McNamee, 2008-11-17 17:23:12]

http://codereview.chromium.org/11801/diff/1/12
File chrome/common/logging_chrome.cc (left):

http://codereview.chromium.org/11801/diff/1/12#oldcode37
Line 37: #pragma optimize("", off)
It seems like we probably had this for a reason, we probably had a problem with
the compiler optimizing some code away.  Although maybe now that we're calling
into DebugUtil, it won't be a problem.  Nicolas made the original change:

r43460 | nsylvain | 2008-06-04 19:30:21 -0700 (Wed, 04 Jun 2008) | 3 lines

make the purecall and invalid_pointer exception work
in chrome.dll too.

[Nicolas Sylvain, 2008-11-17 18:03:22]

http://codereview.chromium.org/11801/diff/1/12
File chrome/common/logging_chrome.cc (left):

http://codereview.chromium.org/11801/diff/1/12#oldcode37
Line 37: #pragma optimize("", off)
On 2008/11/17 17:23:12, Dean McNamee wrote:
> It seems like we probably had this for a reason, we probably had a problem
with
> the compiler optimizing some code away.  Although maybe now that we're calling
> into DebugUtil, it won't be a problem.  Nicolas made the original change:
> 
> r43460 | nsylvain | 2008-06-04 19:30:21 -0700 (Wed, 04 Jun 2008) | 3 lines
> 
> make the purecall and invalid_pointer exception work
> in chrome.dll too.

I made this change at a couple of places because we have similar functions that
are just calling DebugBreak, and the compiler combines them, so when we look at
the stack strace we don't see the right crasher. We should keep that.

[please use my chromium address, 2008-11-17 18:38:19]

On 2008/11/17 18:03:22, Nicolas Sylvain wrote:
> I made this change at a couple of places because we have similar functions
that
> are just calling DebugBreak, and the compiler combines them, so when we look
at
> the stack strace we don't see the right crasher. We should keep that.

Patch updated accordingly.

[agl, 2008-11-18 18:41:02]

http://codereview.chromium.org/11801/diff/202/407
File webkit/port/loader/IconLoader.cpp (right):

http://codereview.chromium.org/11801/diff/202/407#newcode28
Line 28: #if COMPILER(MSVC)
What's the reason for doing this file differently?

http://codereview.chromium.org/11801/diff/202/404
File webkit/port/platform/chromium/ClipboardChromium.cpp (right):

http://codereview.chromium.org/11801/diff/202/404#newcode28
Line 28: #if COMPILER(MSVC)
... and again

[please use my chromium address, 2008-11-18 19:54:00]

Patch updated. I used different style because these files use webkit style.

I also switched to webkit style in PluginsChromium, as I've seen it being
de-basified.

[Dean McNamee, 2008-11-21 18:33:13]

LG, I'll try to test / commit it today