Fix LargeObjectSpace::Contains to check if addr is in new space.

Fix LargeObjectSpace::Contains to check if addr is in new space.

Otherwise page header check is not quite robust: if there is a smi
at the same offset as Page::is_normal_page field, wrong result would
be returned.

That shouldn't be the problem for paged spaces as objects in those
pages do not span page boundaries and thus cannot mess with ::is_normal_page field.

Committed: http://code.google.com/p/v8/source/detail?r=4270

[antonm, 2010-03-23 11:59:19]

Mads,

may you have a look?

Any other spaces where object could span the page?  LargeObject seems fine as it
only provides Contains(HeapObject*) and thus unless some one fakes HeapObject*,
there should be no problems imho.

Couple of notes:

1) probably new space check should have been moved into IsLargeObjectPage
itself, but it hard for me to tell the performance impact;

2) I keep commented CHECK in the test.  The story is x64 gcc in release mode
seems to be 'very smart' about aliasing and mistakenly breaks the CHECK (the
rest of the test is fine).

[Mads Ager (chromium), 2010-03-23 12:47:30]

LGTM