Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(819)

Unified Diff: chrome/browser/debugger/devtools_manager.cc

Issue 117003: DevTools: Add 'Enable Developer Tools' option into the Advanced tab. Hide dev... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/debugger/devtools_manager.h ('k') | chrome/browser/tab_contents/tab_contents.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/debugger/devtools_manager.cc
===================================================================
--- chrome/browser/debugger/devtools_manager.cc (revision 16977)
+++ chrome/browser/debugger/devtools_manager.cc (working copy)
@@ -6,9 +6,12 @@
#include "chrome/browser/debugger/devtools_window.h"
#include "chrome/browser/debugger/devtools_client_host.h"
+#include "chrome/browser/profile.h"
#include "chrome/browser/renderer_host/render_view_host.h"
#include "chrome/browser/tab_contents/site_instance.h"
#include "chrome/common/devtools_messages.h"
+#include "chrome/common/pref_names.h"
+#include "chrome/common/pref_service.h"
#include "googleurl/src/gurl.h"
DevToolsManager::DevToolsManager() {
@@ -85,6 +88,7 @@
}
void DevToolsManager::OpenDevToolsWindow(RenderViewHost* inspected_rvh) {
+ EnableDevToolsInPrefs(inspected_rvh);
DevToolsClientHost* host = GetDevToolsClientHostFor(inspected_rvh);
if (!host) {
host = new DevToolsWindow(
@@ -165,3 +169,13 @@
inspected_rvh->Send(m);
}
}
+
+void DevToolsManager::EnableDevToolsInPrefs(RenderViewHost* inspected_rvh) {
+ Profile* profile = inspected_rvh->site_instance()->browsing_instance()->
+ profile();
+ if (!profile->GetPrefs()->GetBoolean(prefs::kWebKitDeveloperExtrasEnabled)) {
+ //TODO(pfeldman): Show message box with warning to the user.
+ profile->GetPrefs()->SetBoolean(prefs::kWebKitDeveloperExtrasEnabled,
+ true);
+ }
+}
« no previous file with comments | « chrome/browser/debugger/devtools_manager.h ('k') | chrome/browser/tab_contents/tab_contents.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698